From: Wei Mi <wmi@google.com>
Date: Tue, 29 Aug 2017 21:45:11 +0000 (+0000)
Subject: [LoopUnswitch] Fix a simple bug which disables loop unswitch for select statement
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0488e47901ed6692e73a38a8ca97e0dbb9345920;p=llvm

[LoopUnswitch] Fix a simple bug which disables loop unswitch for select statement

This is to fix PR34257. rL309059 takes an early return when FindLIVLoopCondition
fails to find a loop invariant condition. This is wrong and it will disable loop
unswitch for select. The patch fixes the bug.

Differential Revision: https://reviews.llvm.org/D36985


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@312045 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Transforms/Scalar/LoopUnswitch.cpp b/lib/Transforms/Scalar/LoopUnswitch.cpp
index 4a48d90e716..bf830dd6377 100644
--- a/lib/Transforms/Scalar/LoopUnswitch.cpp
+++ b/lib/Transforms/Scalar/LoopUnswitch.cpp
@@ -705,10 +705,8 @@ bool LoopUnswitch::processCurrentLoop() {
         // unswitch on it if we desire.
         Value *LoopCond = FindLIVLoopCondition(BI->getCondition(),
                                                currentLoop, Changed).first;
-        if (!LoopCond || EqualityPropUnSafe(*LoopCond))
-          continue;
-
-        if (UnswitchIfProfitable(LoopCond, ConstantInt::getTrue(Context), TI)) {
+        if (LoopCond && !EqualityPropUnSafe(*LoopCond) &&
+            UnswitchIfProfitable(LoopCond, ConstantInt::getTrue(Context), TI)) {
           ++NumBranches;
           return true;
         }
diff --git a/test/Transforms/LoopUnswitch/unswitch-select.ll b/test/Transforms/LoopUnswitch/unswitch-select.ll
new file mode 100644
index 00000000000..1caac5af1cf
--- /dev/null
+++ b/test/Transforms/LoopUnswitch/unswitch-select.ll
@@ -0,0 +1,26 @@
+; REQUIRES: asserts
+; RUN: opt < %s -loop-unswitch -disable-output -stats 2>&1| FileCheck %s
+
+; Check the select statement in the loop will be unswitched.
+; CHECK: 1 loop-unswitch - Number of selects unswitched
+define i32 @test(i1 zeroext %x, i32 %a) local_unnamed_addr #0 {
+entry:
+  br label %while.cond
+
+while.cond:                                       ; preds = %while.body, %entry
+  %i.0 = phi i32 [ 0, %entry ], [ %inc, %while.body ]
+  %s.0 = phi i32 [ %a, %entry ], [ %add, %while.body ]
+  %cmp = icmp slt i32 %i.0, 10000
+  br i1 %cmp, label %while.body, label %while.end
+
+while.body:                                       ; preds = %while.cond
+  %cond = select i1 %x, i32 %a, i32 %i.0
+  %add = add nsw i32 %s.0, %cond
+  %inc = add nsw i32 %i.0, 1
+  br label %while.cond
+
+while.end:                                        ; preds = %while.cond
+  %s.0.lcssa = phi i32 [ %s.0, %while.cond ]
+  ret i32 %s.0.lcssa
+}
+