From: Duncan P. N. Exon Smith <dexonsmith@apple.com>
Date: Sun, 3 Mar 2019 20:17:53 +0000 (+0000)
Subject: Modules: Document that ReadASTCore exits its final loop via `return`, NFC
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=044cdb60451a9e64e7aeead8759235a9d9bc6878;p=clang

Modules: Document that ReadASTCore exits its final loop via `return`, NFC

The final loop never breaks.  Document that by following it with
llvm_unreachable.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@355294 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Serialization/ASTReader.cpp b/lib/Serialization/ASTReader.cpp
index 9626418f68..5ad21604f4 100644
--- a/lib/Serialization/ASTReader.cpp
+++ b/lib/Serialization/ASTReader.cpp
@@ -4257,7 +4257,7 @@ ASTReader::ReadASTCore(StringRef FileName,
     }
   }
 
-  return Success;
+  llvm_unreachable("unexpected break; expected return");
 }
 
 ASTReader::ASTReadResult