From: Doug MacEachern <dougm@apache.org>
Date: Thu, 22 Nov 2001 02:58:07 +0000 (+0000)
Subject: dont va_start() in ssl_log() unless we are actually going to log something
X-Git-Tag: 2.0.29~48
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=040e30d4664acc2333457de2652de8f8ffb2a3e4;p=apache

dont va_start() in ssl_log() unless we are actually going to log something


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92123 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/ssl/ssl_engine_log.c b/modules/ssl/ssl_engine_log.c
index 378a29bf16..19cba44e37 100644
--- a/modules/ssl/ssl_engine_log.c
+++ b/modules/ssl/ssl_engine_log.c
@@ -196,7 +196,6 @@ void ssl_log(server_rec *s, int level, const char *msg, ...)
     char *cpA;
 
     /*  initialization  */
-    va_start(ap, msg);
     safe_errno = errno;
     sc = mySrvConfig(s);
 
@@ -251,7 +250,9 @@ void ssl_log(server_rec *s, int level, const char *msg, ...)
     }
 
     /*  create custom message  */
+    va_start(ap, msg);
     apr_vsnprintf(vstr, sizeof(vstr), msg, ap);
+    va_end(ap);
 
     /*  write out SSLog message  */
     if ((add & SSL_ADD_ERRNO) && (add & SSL_ADD_SSLERR))
@@ -309,7 +310,6 @@ void ssl_log(server_rec *s, int level, const char *msg, ...)
     if (sc->fileLogFile != NULL)
         apr_file_flush(sc->fileLogFile);
     errno = safe_errno;
-    va_end(ap);
     return;
 }