From: Martin v. Löwis <martin@v.loewis.de>
Date: Sun, 27 Mar 2011 18:58:52 +0000 (+0200)
Subject: Closes #11696: Fix ID generation in msilib.
X-Git-Tag: v2.7.2rc1~199
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=03f7e235c84f46dfa8da3e66b36a32885dbbb6ea;p=python

Closes #11696: Fix ID generation in msilib.
Patch by Mark Mc Mahon.
---

diff --git a/Lib/msilib/__init__.py b/Lib/msilib/__init__.py
index d7a31c0b62..63f392359b 100644
--- a/Lib/msilib/__init__.py
+++ b/Lib/msilib/__init__.py
@@ -173,9 +173,8 @@ def add_tables(db, module):
         add_data(db, table, getattr(module, table))
 
 def make_id(str):
-    #str = str.replace(".", "_") # colons are allowed
-    for c in " -+~;":
-        str = str.replace(c, "_")
+    identifier_chars = string.ascii_letters + string.digits + "._"
+    str = "".join([c if c in identifier_chars else "_" for c in str])
     if str[0] in (string.digits + "."):
         str = "_" + str
     assert re.match("^[A-Za-z_][A-Za-z0-9_.]*$", str), "FILE"+str
diff --git a/Misc/ACKS b/Misc/ACKS
index c2bcde2867..cc33061f3d 100644
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -529,6 +529,7 @@ Chris McDonough
 Greg McFarlane
 Alan McIntyre
 Michael McLay
+Mark Mc Mahon
 Gordon McMillan
 Caolan McNamara
 Andrew McNamara
diff --git a/Misc/NEWS b/Misc/NEWS
index fcd7b63298..03eab5c4ad 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -47,6 +47,8 @@ Core and Builtins
 Library
 -------
 
+- Issue #11696: Fix ID generation in msilib.
+
 - Issue #9696: Fix exception incorrectly raised by xdrlib.Packer.pack_int when
   trying to pack a negative (in-range) integer.