From: Gunnar Beutner <gunnar.beutner@icinga.com>
Date: Thu, 31 Aug 2017 09:10:14 +0000 (+0200)
Subject: Implement support for cleaning up expired API callbacks
X-Git-Tag: v2.8.0~87^2~26
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=03f5ccd25224a6cace86f7ea5b0b47390188fb8d;p=icinga2

Implement support for cleaning up expired API callbacks

refs #5450
---

diff --git a/lib/remote/jsonrpcconnection.cpp b/lib/remote/jsonrpcconnection.cpp
index ca43a7c91..62466160f 100644
--- a/lib/remote/jsonrpcconnection.cpp
+++ b/lib/remote/jsonrpcconnection.cpp
@@ -194,13 +194,18 @@ void JsonRpcConnection::MessageHandler(const String& jsonString)
 
 		String id = vid;
 
-		auto it = m_ApiCallbacks.find(id);
+		ApiCallbackInfo aci;
 
-		if (it == m_ApiCallbacks.end())
-			return;
+		{
+			boost::mutex::scoped_lock lock(m_ApiCallbacksMutex);
+			auto it = m_ApiCallbacks.find(id);
+
+			if (it == m_ApiCallbacks.end())
+				return;
 
-		ApiCallbackInfo aci = it->second;
-		m_ApiCallbacks.erase(it);
+			aci = it->second;
+			m_ApiCallbacks.erase(it);
+		}
 
 		try {
 			aci.Callback(message);
@@ -301,6 +306,11 @@ Value SetLogPositionHandler(const MessageOrigin::Ptr& origin, const Dictionary::
 	return Empty;
 }
 
+bool ApiCallbackInfo::IsExpired(void) const
+{
+	return Timestamp < Utility::GetTime() - 300;
+}
+
 void JsonRpcConnection::CheckLiveness(void)
 {
 	if (m_Seen < Utility::GetTime() - 60 && (!m_Endpoint || !m_Endpoint->GetSyncing())) {
@@ -308,6 +318,18 @@ void JsonRpcConnection::CheckLiveness(void)
 		    <<  "No messages for identity '" << m_Identity << "' have been received in the last 60 seconds.";
 		Disconnect();
 	}
+
+	{
+		boost::mutex::scoped_lock lock(m_ApiCallbacksMutex);
+
+		for (auto it = m_ApiCallbacks.begin(), last = m_ApiCallbacks.end(); it != last; ) {
+			if (it->second.IsExpired()) {
+				it = m_ApiCallbacks.erase(it);
+			} else {
+				++it;
+			}
+		}
+	}
 }
 
 void JsonRpcConnection::TimeoutTimerHandler(void)
@@ -363,5 +385,8 @@ void JsonRpcConnection::RegisterCallback(const String& id, const boost::function
 	aci.Timestamp = Utility::GetTime();
 	aci.Callback = callback;
 
-	m_ApiCallbacks[id] = aci;
+	{
+		boost::mutex::scoped_lock lock(m_ApiCallbacksMutex);
+		m_ApiCallbacks[id] = aci;
+	}
 }
diff --git a/lib/remote/jsonrpcconnection.hpp b/lib/remote/jsonrpcconnection.hpp
index d91125485..d8d2a863a 100644
--- a/lib/remote/jsonrpcconnection.hpp
+++ b/lib/remote/jsonrpcconnection.hpp
@@ -47,6 +47,8 @@ struct ApiCallbackInfo
 {
 	double Timestamp;
 	boost::function<void (const Dictionary::Ptr&)> Callback;
+
+	bool IsExpired(void) const;
 };
 
 /**
@@ -96,6 +98,7 @@ private:
 	double m_HeartbeatTimeout;
 	boost::mutex m_DataHandlerMutex;
 	std::map<String, ApiCallbackInfo> m_ApiCallbacks;
+	boost::mutex m_ApiCallbacksMutex;
 
 	StreamReadContext m_Context;