From: Jim Jagielski Date: Wed, 13 May 2009 18:04:05 +0000 (+0000) Subject: ap_slotmem_mem no longer exists. We never provide the ptr to X-Git-Tag: 2.3.3~614 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=03eae1f7faf1dfd5ecc4e19a06b575fb93a20536;p=apache ap_slotmem_mem no longer exists. We never provide the ptr to the actual mem. Instead, we rely solely on getter/setter git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@774454 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/include/ap_slotmem.h b/include/ap_slotmem.h index e59ef72096..aac7ea046f 100644 --- a/include/ap_slotmem.h +++ b/include/ap_slotmem.h @@ -100,14 +100,6 @@ struct ap_slotmem_storage_method { * @return APR_SUCCESS if all went well */ apr_status_t (* slotmem_attach)(ap_slotmem_t **new, const char *name, apr_size_t *item_size, unsigned int *item_num, apr_pool_t *pool); - /** - * get the memory ptr associated with this worker slot. - * @param s ap_slotmem_t to use. - * @param item_id item to return for 0 to item_num - * @param mem address to store the pointer to the slot - * @return APR_SUCCESS if all went well - */ - apr_status_t (* slotmem_mem)(ap_slotmem_t *s, unsigned int item_id, void**mem); /** * retrieve the memory associated with this worker slot. * @param s ap_slotmem_t to use. @@ -197,15 +189,6 @@ AP_DECLARE(apr_status_t) ap_slotmem_create(ap_slotmem_storage_method *sm, ap_slo * @return APR_SUCCESS if all went well */ AP_DECLARE(apr_status_t) ap_slotmem_attach(ap_slotmem_storage_method *sm, ap_slotmem_t **new, const char *name, apr_size_t *item_size, unsigned int *item_num, apr_pool_t *pool); -/** - * get the memory associated with this worker slot. - * @param sm ap_slotmem_storage_method provider obtained - * @param s ap_slotmem_t to use. - * @param item_id item to return for 0 to item_num - * @param mem address to store the pointer to the slot - * @return APR_SUCCESS if all went well - */ -AP_DECLARE(apr_status_t) ap_slotmem_mem(ap_slotmem_storage_method *sm, ap_slotmem_t *s, unsigned int item_id, void**mem); /** * retrieve the memory associated with this worker slot. * @param sm ap_slotmem_storage_method provider obtained diff --git a/modules/mem/mod_plainmem.c b/modules/mem/mod_plainmem.c index c087908169..33e63eb0b8 100644 --- a/modules/mem/mod_plainmem.c +++ b/modules/mem/mod_plainmem.c @@ -192,7 +192,6 @@ static const ap_slotmem_storage_method storage = { &slotmem_do, &slotmem_create, &slotmem_attach, - &slotmem_mem, &slotmem_get, &slotmem_put, &slotmem_num_slots, diff --git a/modules/mem/mod_sharedmem.c b/modules/mem/mod_sharedmem.c index 1b83ea8ee8..f66eff8e4f 100644 --- a/modules/mem/mod_sharedmem.c +++ b/modules/mem/mod_sharedmem.c @@ -492,7 +492,6 @@ static const ap_slotmem_storage_method storage = { &slotmem_do, &slotmem_create, &slotmem_attach, - &slotmem_mem, &slotmem_get, &slotmem_put, &slotmem_num_slots, diff --git a/server/slotmem.c b/server/slotmem.c index 2517e2f934..d7ddd06760 100644 --- a/server/slotmem.c +++ b/server/slotmem.c @@ -56,12 +56,6 @@ AP_DECLARE(apr_status_t) ap_slotmem_attach(ap_slotmem_storage_method *sm, return (sm->slotmem_attach(new, name, item_size, item_num, pool)); } -AP_DECLARE(apr_status_t) ap_slotmem_mem(ap_slotmem_storage_method *sm, - ap_slotmem_t *s, unsigned int item_id, void**mem) -{ - return (sm->slotmem_mem(s, item_id, mem)); -} - AP_DECLARE(apr_status_t) ap_slotmem_get(ap_slotmem_storage_method *sm, ap_slotmem_t *s, unsigned int item_id, unsigned char *dest, apr_size_t dest_len)