From: R David Murray <rdmurray@bitdance.com>
Date: Thu, 21 Mar 2013 02:11:40 +0000 (-0400)
Subject: #5712: Preemptively fix some other possible timing issues.
X-Git-Tag: v3.2.4rc1~10
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=03b0116c781f8b2b530c2452d25d9a372c8f3635;p=python

#5712: Preemptively fix some other possible timing issues.
---

diff --git a/Lib/test/test_smtplib.py b/Lib/test/test_smtplib.py
index e5df6c7a60..ec971ea52c 100644
--- a/Lib/test/test_smtplib.py
+++ b/Lib/test/test_smtplib.py
@@ -626,12 +626,12 @@ class SimSMTPChannel(smtpd.SMTPChannel):
         if self.rcpt_response is None:
             super().smtp_RCPT(arg)
             return
-        self.push(self.rcpt_response[self.rcpt_count])
         self.rcpt_count += 1
+        self.push(self.rcpt_response[self.rcpt_count-1])
 
     def smtp_RSET(self, arg):
-        super().smtp_RSET(arg)
         self.rset_count += 1
+        super().smtp_RSET(arg)
 
     def smtp_DATA(self, arg):
         if self.data_response is None:
@@ -794,7 +794,7 @@ class SMTPSimTests(unittest.TestCase):
         with self.assertRaises(smtplib.SMTPSenderRefused):
             smtp.sendmail('John', 'Sally', 'test message')
         self.assertIsNone(smtp.sock)
-        self.assertEqual(self.serv._SMTPchannel.rcpt_count, 0)
+        self.assertEqual(self.serv._SMTPchannel.rset_count, 0)
 
     def test_421_from_rcpt_cmd(self):
         smtp = smtplib.SMTP(HOST, self.port, local_hostname='localhost', timeout=15)