From: Guido van Rossum Date: Tue, 16 Jul 2002 14:30:28 +0000 (+0000) Subject: valid_identifier(): use an unsigned char* so that isalpha() will do X-Git-Tag: v2.3c1~4999 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=03013a0130285c21bb940c89f0538f8ed1d35622;p=python valid_identifier(): use an unsigned char* so that isalpha() will do the right thing even if char is unsigned. --- diff --git a/Objects/typeobject.c b/Objects/typeobject.c index a7afa9b7f0..a7263d8e77 100644 --- a/Objects/typeobject.c +++ b/Objects/typeobject.c @@ -962,7 +962,7 @@ static PyObject *bozo_obj = NULL; static int valid_identifier(PyObject *s) { - char *p; + unsigned char *p; int i, n; if (!PyString_Check(s)) { @@ -970,7 +970,7 @@ valid_identifier(PyObject *s) "__slots__ must be strings"); return 0; } - p = PyString_AS_STRING(s); + p = (unsigned char *) PyString_AS_STRING(s); n = PyString_GET_SIZE(s); /* We must reject an empty name. As a hack, we bump the length to 1 so that the loop will balk on the trailing \0. */