From: Reid Kleckner <rnk@google.com>
Date: Thu, 5 May 2016 20:58:46 +0000 (+0000)
Subject: [codeview] Improve some comments
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=02f474a115d6c7d3ab8c134672b4d0b3aeb155d5;p=llvm

[codeview] Improve some comments

This FIXME was already fixed, and these LF_* enum names were
inconsistent.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@268683 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/include/llvm/DebugInfo/CodeView/TypeRecord.h b/include/llvm/DebugInfo/CodeView/TypeRecord.h
index d6b323c8d83..cd70bcf3b73 100644
--- a/include/llvm/DebugInfo/CodeView/TypeRecord.h
+++ b/include/llvm/DebugInfo/CodeView/TypeRecord.h
@@ -299,7 +299,7 @@ struct FuncId {
   // Name: The null-terminated name follows.
 };
 
-// LF_CLASS, LF_STRUCT, LF_INTERFACE
+// LF_CLASS, LF_STRUCTURE, LF_INTERFACE
 struct ClassType {
   ulittle16_t MemberCount; // Number of members in FieldList.
   ulittle16_t Properties;  // ClassOptions bitset
@@ -501,6 +501,7 @@ struct OneMethod {
   bool isIntroducedVirtual() const { return Attrs.isIntroducedVirtual(); }
 };
 
+// LF_METHODLIST
 struct MethodListEntry {
   MemberAttributes Attrs;
   ulittle16_t Padding;
@@ -559,7 +560,7 @@ struct BaseClass {
   // BaseOffset: LF_NUMERIC encoded byte offset of base from derived.
 };
 
-// LF_VBCLASS | LV_IVBCLASS
+// LF_VBCLASS, LF_IVBCLASS
 struct VirtualBaseClass {
   MemberAttributes Attrs; // Access control attributes, etc.
   TypeIndex BaseType;     // Base class type
diff --git a/lib/DebugInfo/CodeView/TypeDumper.cpp b/lib/DebugInfo/CodeView/TypeDumper.cpp
index 8139484a6a0..bb3859a0590 100644
--- a/lib/DebugInfo/CodeView/TypeDumper.cpp
+++ b/lib/DebugInfo/CodeView/TypeDumper.cpp
@@ -200,7 +200,6 @@ public:
       : CVTD(CVTD), W(W), PrintRecordBytes(PrintRecordBytes) {}
 
   /// CVTypeVisitor overrides.
-  /// FIXME: Bury these in the .cc file to hide implementation details.
 #define TYPE_RECORD(ClassName, LeafEnum)                                       \
   void visit##ClassName(TypeLeafKind LeafType, const ClassName *Record,        \
                         ArrayRef<uint8_t> LeafData);