From: Max Kirillov Date: Sat, 24 Nov 2018 13:48:27 +0000 (+0200) Subject: http-backend: enable cleaning up forked upload/receive-pack on exit X-Git-Tag: v2.21.0-rc0~125^2 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=02818a98d7bddbc036fe6a1ceea847c6de20ed00;p=git http-backend: enable cleaning up forked upload/receive-pack on exit If http-backend dies because of errors, started upload-pack or receive-pack are not killed and waited, but rather stay running for some time until they exit because of closed stdin. It may be undesirable in working environment, and it also causes occasional failure of t5562, because the processes keep opened act.err, and sometimes write there errors after next test started using the file. Fix by enabling cleaning of the command at http-backed exit. Reported-by: Carlo Arenas Helped-by: Carlo Arenas Signed-off-by: Max Kirillov Signed-off-by: Junio C Hamano --- diff --git a/http-backend.c b/http-backend.c index 458642ef72..ebf268cace 100644 --- a/http-backend.c +++ b/http-backend.c @@ -486,6 +486,8 @@ static void run_service(const char **argv, int buffer_input) if (buffer_input || gzipped_request || req_len >= 0) cld.in = -1; cld.git_cmd = 1; + cld.clean_on_exit = 1; + cld.wait_after_clean = 1; if (start_command(&cld)) exit(1);