From: Artyom Skrobov Date: Fri, 13 Dec 2013 13:43:48 +0000 (+0000) Subject: clang-check to ignore -no-integrated-as because certain drivers can't handle it X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=025b9aae94116d3e23604d0f3cd85bcce8e085b9;p=clang clang-check to ignore -no-integrated-as because certain drivers can't handle it git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@197229 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Tooling/CompilationDatabase.cpp b/lib/Tooling/CompilationDatabase.cpp index 286beb7ae2..7bbae12dbf 100644 --- a/lib/Tooling/CompilationDatabase.cpp +++ b/lib/Tooling/CompilationDatabase.cpp @@ -204,8 +204,8 @@ private: /// \li true if successful. /// \li false if \c Args cannot be used for compilation jobs (e.g. /// contains an option like -E or -version). -bool stripPositionalArgs(std::vector Args, - std::vector &Result) { +static bool stripPositionalArgs(std::vector Args, + std::vector &Result) { IntrusiveRefCntPtr DiagOpts = new DiagnosticOptions(); UnusedInputDiagConsumer DiagClient; DiagnosticsEngine Diagnostics( @@ -237,6 +237,10 @@ bool stripPositionalArgs(std::vector Args, // up with no jobs but then this is the user's fault. Args.push_back("placeholder.cpp"); + // Remove -no-integrated-as; it's not used for syntax checking, + // and it confuses targets which don't support this option. + std::remove_if(Args.begin(), Args.end(), MatchesAny(std::string("no-integrated-as"))); + const OwningPtr Compilation( NewDriver->BuildCompilation(Args)); diff --git a/test/Tooling/multi-jobs.cpp b/test/Tooling/multi-jobs.cpp index cef84439f0..db8e949408 100644 --- a/test/Tooling/multi-jobs.cpp +++ b/test/Tooling/multi-jobs.cpp @@ -2,6 +2,3 @@ // CHECK: C++ requires invalid; - -// MSVC targeted drivers (*-win32) are incapable of invoking external assembler. -// XFAIL: win32