From: Todd C. Miller <Todd.Miller@courtesan.com>
Date: Fri, 4 Oct 2013 22:22:25 +0000 (-0600)
Subject: When checking for unused Runas_Aliases, count those used as part
X-Git-Tag: SUDO_1_8_9^2~170
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=020fb00948bbea4643111dea70cdd1f2f0e8cc54;p=sudo

When checking for unused Runas_Aliases, count those used as part
of a Runas Group too.  Fixes a false positive warning.
---

diff --git a/plugins/sudoers/visudo.c b/plugins/sudoers/visudo.c
index 2851ced1f..4d788e7a6 100644
--- a/plugins/sudoers/visudo.c
+++ b/plugins/sudoers/visudo.c
@@ -1202,6 +1202,12 @@ check_aliases(bool strict, bool quiet)
 			    errors++;
 		    }
 		}
+		tq_foreach_fwd(&cs->runasgrouplist, m) {
+		    if (m->type == ALIAS) {
+			if (!alias_remove_recursive(m->name, RUNASALIAS))
+			    errors++;
+		    }
+		}
 		if ((m = cs->cmnd)->type == ALIAS) {
 		    if (!alias_remove_recursive(m->name, CMNDALIAS))
 			errors++;