From: Marcela Mašláňová <mmaslano@redhat.com>
Date: Mon, 21 Dec 2009 12:58:08 +0000 (+0100)
Subject: Cron doesn't use environment values from /etc/security/pam_env.conf.
X-Git-Tag: cronie1.4.4~8
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=01f1ef96a3983bedcd5e908e080530f882ff6518;p=cronie

Cron doesn't use environment values from /etc/security/pam_env.conf.
This was fixed by moving pam_setcred into first part of authentication
of pam.
---

diff --git a/src/security.c b/src/security.c
index c41c06b..5a2cdfa 100644
--- a/src/security.c
+++ b/src/security.c
@@ -159,6 +159,8 @@ int cron_start_pam(struct passwd *pw) {
 	PAM_FAIL_CHECK;
 	retcode = pam_acct_mgmt(pamh, PAM_SILENT);
 	PAM_FAIL_CHECK;
+	retcode = pam_setcred(pamh, PAM_ESTABLISH_CRED | PAM_SILENT);
+	PAM_FAIL_CHECK;
 #endif
 
 	return retcode;
@@ -168,8 +170,6 @@ static int cron_open_pam_session(struct passwd *pw) {
 	int retcode = 0;
 
 #if defined(WITH_PAM)
-	retcode = pam_setcred(pamh, PAM_ESTABLISH_CRED | PAM_SILENT);
-	PAM_FAIL_CHECK;
 	retcode = pam_open_session(pamh, PAM_SILENT);
 	PAM_FAIL_CHECK;
 	if (retcode == PAM_SUCCESS)