From: Martin Kraemer <martin@php.net>
Date: Wed, 28 Jan 2004 16:25:12 +0000 (+0000)
Subject: Bug fix: Images would be broken on big-endian machines because the putc
X-Git-Tag: php-5.0.0b4RC1~256
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=01c6257c5c8d6d0473271c006392b5d43f1214e9;p=php

Bug fix: Images would be broken on big-endian machines because the putc
function wrote the first (instead of "the low order") byte. That resulted
in unexpected zero bytes.
---

diff --git a/ext/gd/gd_ctx.c b/ext/gd/gd_ctx.c
index d1ec8e0c25..6fb7b84ce4 100644
--- a/ext/gd/gd_ctx.c
+++ b/ext/gd/gd_ctx.c
@@ -24,8 +24,13 @@
 
 static void _php_image_output_putc(struct gdIOCtx *ctx, int c)
 {
+	/* without the following downcast, the write will fail
+	 * (i.e., will write a zero byte) for all
+	 * big endian architectures:
+	 */
+	unsigned char ch = (unsigned char) c;
 	TSRMLS_FETCH();
-	php_write(&c, 1 TSRMLS_CC);
+	php_write(&ch, 1 TSRMLS_CC);
 }
 
 static int _php_image_output_putbuf(struct gdIOCtx *ctx, const void* buf, int l)