From: Hubert Tong Date: Fri, 2 Aug 2019 19:26:05 +0000 (+0000) Subject: [Driver][test] Avoid undefined grep in darwin-ld.c X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0165340d205499f0904110b90f4ec1df5657a8c6;p=clang [Driver][test] Avoid undefined grep in darwin-ld.c Summary: question-mark is not a BRE special character. POSIX.1-2017 XBD Section 9.3.2 indicates that the interpretation of `\?` as used by rC366282 is undefined. This patch uses an ERE instead. Reviewers: rnk, daltenty, xingxue, jasonliu Reviewed By: rnk Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D65668 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@367709 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/test/Driver/darwin-ld.c b/test/Driver/darwin-ld.c index eb357a9819..4450829842 100644 --- a/test/Driver/darwin-ld.c +++ b/test/Driver/darwin-ld.c @@ -5,9 +5,9 @@ // Make sure we run dsymutil on source input files. // RUN: %clang -target i386-apple-darwin9 -### -g %s -o BAR 2> %t.log -// RUN: grep '".*dsymutil\(.exe\)\?" "-o" "BAR.dSYM" "BAR"' %t.log +// RUN: grep -E '".*dsymutil(\.exe)?" "-o" "BAR.dSYM" "BAR"' %t.log // RUN: %clang -target i386-apple-darwin9 -### -g -filelist FOO %s -o BAR 2> %t.log -// RUN: grep '".*dsymutil\(.exe\)\?" "-o" "BAR.dSYM" "BAR"' %t.log +// RUN: grep -E '".*dsymutil(\.exe)?" "-o" "BAR.dSYM" "BAR"' %t.log // Check linker changes that came with new linkedit format. // RUN: touch %t.o