From: Guido van Rossum <guido@python.org>
Date: Mon, 23 Nov 1998 21:09:51 +0000 (+0000)
Subject: Whoops!  One the "redundant" initializations removed by Vladimir in
X-Git-Tag: v1.5.2b1~200
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=014518f66cbf8c93ca6c75d005956b6f622727a8;p=python

Whoops!  One the "redundant" initializations removed by Vladimir in
the previous patch wasn't -- there was a path through the code that
bypassed all initializations.  Thanks to Just for reporting the bug!
---

diff --git a/Python/ceval.c b/Python/ceval.c
index e3660727b2..bcc2288d8b 100644
--- a/Python/ceval.c
+++ b/Python/ceval.c
@@ -364,7 +364,7 @@ eval_code2(co, globals, locals,
 	register PyObject *t;
 	register PyFrameObject *f; /* Current frame */
 	register PyObject **fastlocals;
-	PyObject *retval;	/* Return value */
+	PyObject *retval = NULL;	/* Return value */
 	PyThreadState *tstate = PyThreadState_Get();
 	unsigned char *first_instr;
 #ifdef LLTRACE
@@ -1769,7 +1769,7 @@ eval_code2(co, globals, locals,
 			if (tstate->sys_profilefunc)
 				call_exc_trace(&tstate->sys_profilefunc,
 					       (PyObject**)0, f);
-}
+		}
 		
 		/* For the rest, treat WHY_RERAISE as WHY_EXCEPTION */