From: Victor Stinner <victor.stinner@haypocalc.com>
Date: Mon, 9 May 2011 23:30:03 +0000 (+0200)
Subject: faulthandler: improve_sigabrt() on Visual Studio
X-Git-Tag: v3.3.0a1~2326
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=00bc6ccb786aa2976cc6c405738247359539854c;p=python

faulthandler: improve_sigabrt() on Visual Studio

Use _set_abort_behavior() + abort() instead of raise(SIGABRT) which may write
an error message and/or open a popup asking to report the fault.
---

diff --git a/Modules/faulthandler.c b/Modules/faulthandler.c
index 6cf06ad242..3549af5367 100644
--- a/Modules/faulthandler.c
+++ b/Modules/faulthandler.c
@@ -816,14 +816,12 @@ faulthandler_sigfpe(PyObject *self, PyObject *args)
 static PyObject *
 faulthandler_sigabrt(PyObject *self, PyObject *args)
 {
-#if _MSC_VER
-    /* If Python is compiled in debug mode with Visual Studio, abort() opens
-       a popup asking the user how to handle the assertion. Use raise(SIGABRT)
-       instead. */
-    raise(SIGABRT);
-#else
-    abort();
+#ifdef _MSC_VER
+    /* Visual Studio: configure abort() to not display an error message nor
+       open a popup asking to report the fault. */
+    _set_abort_behavior(0, _WRITE_ABORT_MSG | _CALL_REPORTFAULT);
 #endif
+    abort();
     Py_RETURN_NONE;
 }