From: Douglas Gregor Date: Thu, 12 Nov 2009 15:31:47 +0000 (+0000) Subject: Improve source-location information for implicitly-generated member call expressions X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=00b98c229ef28a5e82943bb23d09fb46d24ca381;p=clang Improve source-location information for implicitly-generated member call expressions git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@86989 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/include/clang/AST/ExprCXX.h b/include/clang/AST/ExprCXX.h index 5931a3fcf9..9e6fd4fd06 100644 --- a/include/clang/AST/ExprCXX.h +++ b/include/clang/AST/ExprCXX.h @@ -95,6 +95,8 @@ public: /// operation would return "x". Expr *getImplicitObjectArgument(); + virtual SourceRange getSourceRange() const; + static bool classof(const Stmt *T) { return T->getStmtClass() == CXXMemberCallExprClass; } diff --git a/lib/AST/ExprCXX.cpp b/lib/AST/ExprCXX.cpp index 7c6fc41ef1..0ba4608ee1 100644 --- a/lib/AST/ExprCXX.cpp +++ b/lib/AST/ExprCXX.cpp @@ -323,6 +323,14 @@ Expr *CXXMemberCallExpr::getImplicitObjectArgument() { return 0; } +SourceRange CXXMemberCallExpr::getSourceRange() const { + SourceLocation LocStart = getCallee()->getLocStart(); + if (LocStart.isInvalid() && getNumArgs() > 0) + LocStart = getArg(0)->getLocStart(); + return SourceRange(LocStart, getRParenLoc()); +} + + //===----------------------------------------------------------------------===// // Named casts //===----------------------------------------------------------------------===// diff --git a/lib/Sema/SemaExprCXX.cpp b/lib/Sema/SemaExprCXX.cpp index 94550e6f19..964334b20b 100644 --- a/lib/Sema/SemaExprCXX.cpp +++ b/lib/Sema/SemaExprCXX.cpp @@ -2120,7 +2120,7 @@ CXXMemberCallExpr *Sema::BuildCXXMemberCallExpr(Expr *Exp, CXXMemberCallExpr *CE = new (Context) CXXMemberCallExpr(Context, ME, 0, 0, ResultType, - SourceLocation()); + Exp->getLocEnd()); return CE; }