From: Petri Lehtinen <petri@digip.org>
Date: Thu, 16 Feb 2012 19:42:34 +0000 (+0200)
Subject: Fix errors in sqlite3's Cursor.rowcount documentation
X-Git-Tag: v2.7.3rc1~48
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=002b202009e5d887f6ff075e428319849cfd865b;p=python

Fix errors in sqlite3's Cursor.rowcount documentation

Closes #13995.
---

diff --git a/Doc/includes/sqlite3/shortcut_methods.py b/Doc/includes/sqlite3/shortcut_methods.py
index 72ed4b3712..e128a3bf60 100644
--- a/Doc/includes/sqlite3/shortcut_methods.py
+++ b/Doc/includes/sqlite3/shortcut_methods.py
@@ -17,5 +17,4 @@ con.executemany("insert into person(firstname, lastname) values (?, ?)", persons
 for row in con.execute("select firstname, lastname from person"):
     print row
 
-# Using a dummy WHERE clause to not let SQLite take the shortcut table deletes.
-print "I just deleted", con.execute("delete from person where 1=1").rowcount, "rows"
+print "I just deleted", con.execute("delete from person").rowcount, "rows"
diff --git a/Doc/library/sqlite3.rst b/Doc/library/sqlite3.rst
index 051ac92ca7..80803aa351 100644
--- a/Doc/library/sqlite3.rst
+++ b/Doc/library/sqlite3.rst
@@ -548,18 +548,17 @@ Cursor Objects
    attribute, the database engine's own support for the determination of "rows
    affected"/"rows selected" is quirky.
 
-   For ``DELETE`` statements, SQLite reports :attr:`rowcount` as 0 if you make a
-   ``DELETE FROM table`` without any condition.
-
    For :meth:`executemany` statements, the number of modifications are summed up
    into :attr:`rowcount`.
 
    As required by the Python DB API Spec, the :attr:`rowcount` attribute "is -1 in
    case no ``executeXX()`` has been performed on the cursor or the rowcount of the
-   last operation is not determinable by the interface".
+   last operation is not determinable by the interface". This includes ``SELECT``
+   statements because we cannot determine the number of rows a query produced
+   until all rows were fetched.
 
-   This includes ``SELECT`` statements because we cannot determine the number of
-   rows a query produced until all rows were fetched.
+   With SQLite versions before 3.6.5, :attr:`rowcount` is set to 0 if
+   you make a ``DELETE FROM table`` without any condition.
 
 .. attribute:: Cursor.lastrowid
 
diff --git a/Misc/NEWS b/Misc/NEWS
index 4ae21b6ee2..1b1d02c6fa 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -575,6 +575,8 @@ Tests
 Documentation
 -------------
 
+- Issue #13995: Fix errors in sqlite3's Cursor.rowcount documentation
+
 - Issue #13402: Document absoluteness of sys.executable.
 
 - Issue #13883: PYTHONCASEOK also works on OS X, OS/2, and RiscOS.