From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Thu, 12 May 2022 04:31:29 +0000 (-0700)
Subject: gv2gml: remove 'outFile' parameter to 'emitNodeAttrs'
X-Git-Tag: 4.0.0~31^2~6
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=000146e73e84570723c06e65ee6d7b3ac7f3b078;p=graphviz

gv2gml: remove 'outFile' parameter to 'emitNodeAttrs'

The only call to this function passes `outFile`, an already available global
that this parameter was shadowing. This removes numerous -Wshadow warnings.
---

diff --git a/cmd/tools/gv2gml.c b/cmd/tools/gv2gml.c
index d378815a7..ddb323a39 100644
--- a/cmd/tools/gv2gml.c
+++ b/cmd/tools/gv2gml.c
@@ -244,9 +244,7 @@ emitAttr (char* name, char* value, FILE* outFile, int ix)
  * graphics
  * LabelGraphics
  */
-static void 
-emitNodeAttrs (Agraph_t* G, Agnode_t* np, FILE* outFile, int ix)
-{
+static void  emitNodeAttrs(Agraph_t *G, Agnode_t *np, int ix) {
     Agsym_t*  s;
     char* v;
     node_attrs attrs;
@@ -433,7 +431,7 @@ static void emitNode(Agraph_t *G, Agnode_t *n) {
     fprintf(outFile, "  node [\n    id %" PRIu64 "\n    name \"%s\"\n", id,
             agnameof(n));
     ID(n) = id++;
-    emitNodeAttrs (G, n, outFile, 2);
+    emitNodeAttrs(G, n, 2);
     fprintf (outFile, "  ]\n");
 
 }