]> granicus.if.org Git - php/commitdiff
Promote warning to exception in ext/posix
authorMáté Kocsis <kocsismate@woohoolabs.com>
Tue, 18 Aug 2020 12:24:46 +0000 (14:24 +0200)
committerMáté Kocsis <kocsismate@woohoolabs.com>
Mon, 24 Aug 2020 15:34:33 +0000 (17:34 +0200)
Closes GH-6009

ext/posix/posix.c

index cc3dd42cbc75cbfa8145093ab5ad7d3542b3f058..bb86b5324b59b9c317bb9e3fd37e6a530eacfebb 100644 (file)
@@ -655,14 +655,9 @@ PHP_FUNCTION(posix_mknod)
        }
 
        if ((mode & S_IFCHR) || (mode & S_IFBLK)) {
-               if (ZEND_NUM_ARGS() == 2) {
-                       php_error_docref(NULL, E_WARNING, "For S_IFCHR and S_IFBLK you need to pass a major device kernel identifier");
-                       RETURN_FALSE;
-               }
                if (major == 0) {
-                       php_error_docref(NULL, E_WARNING,
-                               "Expects argument 3 to be non-zero for POSIX_S_IFCHR and POSIX_S_IFBLK");
-                       RETURN_FALSE;
+                       zend_argument_value_error(3, "cannot be 0 for the POSIX_S_IFCHR and POSIX_S_IFBLK modes");
+                       RETURN_THROWS();
                } else {
 #if defined(HAVE_MAKEDEV) || defined(makedev)
                        php_dev = makedev(major, minor);