getparam: fix the GetStr() macro

It should return PARAM_NO_MEM if the strdup fails. Spotted by
clang-analyzer

diff --git a/src/tool_getparam.c b/src/tool_getparam.c
index 579437eb778e1cab3ff7e9e130ccc2293f989202..685c224de3b9a04f9be0ab4bd3dee148812417b9 100644 (file)
--- a/src/tool_getparam.c
+++ b/src/tool_getparam.c
@@ -56,10 +56,11 @@
     free(*(str)); \
     *(str) = NULL; \
   } \
-  if((val)) \
+  if((val)) {              \
     *(str) = strdup((val)); \
-  if(!(val)) \
-    return PARAM_NO_MEM; \
+    if(!(*(str)))          \
+      return PARAM_NO_MEM; \
+  } \
 } WHILE_FALSE
 
 struct LongShort {