]> granicus.if.org Git - php/commitdiff
Fixed new hash API usage
authorDmitry Stogov <dmitry@zend.com>
Sat, 17 May 2014 07:48:29 +0000 (11:48 +0400)
committerDmitry Stogov <dmitry@zend.com>
Sat, 17 May 2014 07:48:29 +0000 (11:48 +0400)
ext/opcache/Optimizer/block_pass.c
ext/opcache/Optimizer/compact_literals.c

index f108012bbd91bde3ee45ad2a8577403b622e16ab..3316e5233720c0a4ac3bb7209228b89d35f3f06b 100644 (file)
@@ -751,7 +751,7 @@ static void zend_optimize_block(zend_code_block *block, zend_op_array *op_array,
                                                  (flen == sizeof("is_callable")-1 && zend_binary_strcasecmp(fname, flen, "is_callable", sizeof("is_callable")-1) == 0)
                                                  ) {
                                        zend_function *function;
-                                       if(zend_hash_find(EG(function_table), Z_STRVAL_P(arg), Z_STRLEN_P(arg)+1, (void **)&function) == SUCCESS) {
+                                       if(zend_hash_find(EG(function_table), Z_STRVAL_P(arg), Z_STRLEN_P(arg)+1, (void **)&function) != NULL) {
                                                literal_dtor(arg);
                                                MAKE_NOP(sv);
                                                MAKE_NOP(fcall);
index 80a75f5808df4285952809addb4f5e21f93f5f3e..aad6243e0a31266efc49244fc3bb111c51b95cec 100644 (file)
@@ -324,7 +324,7 @@ static void optimizer_compact_literals(zend_op_array *op_array TSRMLS_DC)
                                        map[i] = l_true;
                                        break;
                                case IS_LONG:
-                                       if ((pos = zend_hash_index_find(&hash, Z_LVAL(op_array->literals[i]))) != 0) {
+                                       if ((pos = zend_hash_index_find(&hash, Z_LVAL(op_array->literals[i]))) != NULL) {
                                                map[i] = Z_LVAL_P(pos);
                                        } else {
                                                map[i] = j;
@@ -338,7 +338,7 @@ static void optimizer_compact_literals(zend_op_array *op_array TSRMLS_DC)
                                        }
                                        break;
                                case IS_DOUBLE:
-                                       if ((pos = zend_hash_str_find(&hash, (char*)&Z_DVAL(op_array->literals[i]), sizeof(double))) != 0) {
+                                       if ((pos = zend_hash_str_find(&hash, (char*)&Z_DVAL(op_array->literals[i]), sizeof(double))) != NULL) {
                                                map[i] = Z_LVAL_P(pos);
                                        } else {
                                                map[i] = j;
@@ -375,7 +375,7 @@ static void optimizer_compact_literals(zend_op_array *op_array TSRMLS_DC)
                                                key->h += info[i].flags;
                                        }
                                        if ((info[i].flags & LITERAL_MAY_MERGE) &&
-                                               (pos = zend_hash_find(&hash, key)) != 0 &&
+                                               (pos = zend_hash_find(&hash, key)) != NULL &&
                                                Z_TYPE(op_array->literals[i]) == Z_TYPE(op_array->literals[Z_LVAL_P(pos)]) &&
                                                info[i].flags == info[Z_LVAL_P(pos)].flags) {