]> granicus.if.org Git - python/commitdiff
Try to make signal-sending tests in test_subprocess more robust on slow machines
authorAntoine Pitrou <solipsis@pitrou.net>
Sun, 19 Sep 2010 23:06:53 +0000 (23:06 +0000)
committerAntoine Pitrou <solipsis@pitrou.net>
Sun, 19 Sep 2010 23:06:53 +0000 (23:06 +0000)
Lib/test/test_subprocess.py

index 5cc8903e7c2208c3269b55e5457002079cfd62d1..7341b0b681014873e79910186712d9328c837727 100644 (file)
@@ -830,16 +830,18 @@ class POSIXProcessTestCase(BaseTestCase):
                              stdin=subprocess.PIPE, stderr=subprocess.PIPE)
 
         # Let the process initialize (Issue #3137)
-        time.sleep(0.1)
+        time.sleep(0.4)
         # The process should not terminate prematurely
         self.assertIsNone(p.poll())
         # Retry if the process do not receive the signal.
-        count, maxcount = 0, 3
+        count, maxcount = 0, 10
         while count < maxcount and p.poll() is None:
             getattr(p, method)(*args)
             time.sleep(0.1)
             count += 1
 
+        if count == maxcount:
+            self.skipTest("apparently failed to send the signal")
         self.assertIsNotNone(p.poll(), "the subprocess did not terminate")
         if count > 1:
             print("p.{}{} succeeded after "