]> granicus.if.org Git - php/commitdiff
Fix int/size_t confusion in isValidPharFilename (bug #73580)
authorStanislav Malyshev <stas@php.net>
Fri, 25 Nov 2016 21:42:35 +0000 (13:42 -0800)
committerStanislav Malyshev <stas@php.net>
Sat, 26 Nov 2016 02:57:18 +0000 (18:57 -0800)
ext/phar/phar_object.c

index f3e98a6d96f3ed3a101a20837f0b4b4366c2af4d..28ec8a3411efd1f3940b55399f3fa2c0e791866e 100644 (file)
@@ -1062,6 +1062,10 @@ PHP_METHOD(Phar, isValidPharFilename)
                return;
        }
 
+       if (ZEND_SIZE_T_INT_OVFL(fname_len)) {
+               RETURN_FALSE;
+       }
+
        is_executable = executable;
        RETVAL_BOOL(phar_detect_phar_fname_ext(fname, fname_len, &ext_str, &ext_len, is_executable, 2, 1) == SUCCESS);
 }