patch 8.1.2334: possible NULL pointer dereference in popup_locate()

Problem:    Possible NULL pointer dereference in popup_locate(). (Coverity)
Solution:   Check for NULL pointer.

diff --git a/src/popupwin.c b/src/popupwin.c
index efcc3959817bf8cc0ac876c5291a2a4ccf3813a1..3b808e2e3ab13b87a2ba3c6e4c911308d5da58f4 100644 (file)
--- a/src/popupwin.c
+++ b/src/popupwin.c
@@ -2599,7 +2599,7 @@ f_popup_locate(typval_T *argvars, typval_T *rettv)
     win_T      *wp;
 
     wp = mouse_find_win(&row, &col, FIND_POPUP);
-    if (WIN_IS_POPUP(wp))
+    if (wp != NULL && WIN_IS_POPUP(wp))
        rettv->vval.v_number = wp->w_id;
 }
 

diff --git a/src/version.c b/src/version.c
index 903734998da418c21daa99d79e5951fb97b5f299..c327f98b4b37cd1bc75f26238fac2005437b1737 100644 (file)
--- a/src/version.c
+++ b/src/version.c
@@ -737,6 +737,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    2334,
 /**/
     2333,
 /**/