BFILE tests are only valid when Oracle is installed on the same host

skip them if it's not

diff --git a/ext/oci8/tests/connect.inc b/ext/oci8/tests/connect.inc
index 887c8fdaa107eda36774b5a60ed486040ad2bc41..452976e8fe4577dfc3ee51e31bc45828d8a3f8e0 100644 (file)
--- a/ext/oci8/tests/connect.inc
+++ b/ext/oci8/tests/connect.inc
@@ -1,13 +1,6 @@
 <?php
 
-/* 
- * Please, change user, password and dbase to match your configuration.
- * 
- * */
- 
-$user       = "system";
-$password   = "system";
-$dbase      = "oracle";
+include "details.inc";
 
 /* 
  * You should have privileges to create tables in this schema 

diff --git a/ext/oci8/tests/details.inc b/ext/oci8/tests/details.inc
new file mode 100644 (file)
index 0000000..6cf13ac
--- /dev/null
+++ b/ext/oci8/tests/details.inc
@@ -0,0 +1,16 @@
+<?php
+
+/* 
+* Please, change user, password and dbase to match your configuration.
+* 
+* */
+
+$user       = "system";
+$password   = "system";
+$dbase      = "oracle";
+
+/* Set this variable to TRUE if Oracle is installed @ localhost */
+
+$oracle_on_localhost = FALSE;
+
+?>

diff --git a/ext/oci8/tests/lob_029.phpt b/ext/oci8/tests/lob_029.phpt
index 6dc9182257da5845e4990bbbd910c77d45fcfeab..fb49dce2053cec6680541cef2b2dee509ce0b701 100644 (file)
--- a/ext/oci8/tests/lob_029.phpt
+++ b/ext/oci8/tests/lob_029.phpt
@@ -1,7 +1,11 @@
 --TEST--
 reading/writing BFILE LOBs
 --SKIPIF--
-<?php if (!extension_loaded('oci8')) die("skip no oci8 extension"); ?>
+<?php 
+if (!extension_loaded('oci8')) die("skip no oci8 extension"); 
+include "details.inc";
+if (empty($oracle_on_localhost)) die("skip this test won't work with remote Oracle");
+?>
 --FILE--
 <?php