]> granicus.if.org Git - llvm/commitdiff
[CMake][LLVM] Remove duplicated library mask. Broken clang linking against clangShared
authorOleg Ranevskyy <oranevskyy@accesssoftek.com>
Thu, 10 Aug 2017 13:37:58 +0000 (13:37 +0000)
committerOleg Ranevskyy <oranevskyy@accesssoftek.com>
Thu, 10 Aug 2017 13:37:58 +0000 (13:37 +0000)
Summary:
The `LLVM${c}Info` mask is listed twice in LLVM-Config.cmake. This results in the libraries such as LLVMARMInfo, LLVMAArch4Info, etc appearing twice in `extract_symbols.py` command line while building `clangShared`. `Extract_symbols.py` does not work well in such a case and completely ignores the symbols from the duplicated libraries. Thus, the LLVM(...)Info symbols do not get exported from `clangShared` and linking clang against it fails with unresolved dependencies.

Seems to be a mere copy-paste mistake.

Reviewers: beanz, chapuni

Reviewed By: chapuni

Subscribers: chapuni, aemerson, mgorny, kristof.beyls, llvm-commits, asl

Differential Revision: https://reviews.llvm.org/D36119

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@310590 91177308-0d34-0410-b5e6-96231b3b80d8

cmake/modules/LLVM-Config.cmake

index 52330151065b69c0d7e7c1b51f0874061ae029c7..2b9ab23c47704cfb588d6dba11ebf263527aa930 100644 (file)
@@ -175,18 +175,15 @@ function(llvm_map_components_to_libnames out_libs)
           message(FATAL_ERROR "Target ${c} is not in the set of libraries.")
         endif()
       endif()
-      if( TARGET LLVM${c}AsmPrinter )
-        list(APPEND expanded_components "LLVM${c}AsmPrinter")
-      endif()
       if( TARGET LLVM${c}AsmParser )
         list(APPEND expanded_components "LLVM${c}AsmParser")
       endif()
+      if( TARGET LLVM${c}AsmPrinter )
+        list(APPEND expanded_components "LLVM${c}AsmPrinter")
+      endif()
       if( TARGET LLVM${c}Desc )
         list(APPEND expanded_components "LLVM${c}Desc")
       endif()
-      if( TARGET LLVM${c}Info )
-        list(APPEND expanded_components "LLVM${c}Info")
-      endif()
       if( TARGET LLVM${c}Disassembler )
         list(APPEND expanded_components "LLVM${c}Disassembler")
       endif()