]> granicus.if.org Git - taglib/commitdiff
Don't require users to include a padding byte explicitly
authorScott Wheeler <scott@directededge.com>
Mon, 18 May 2015 14:41:30 +0000 (16:41 +0200)
committerScott Wheeler <scott@directededge.com>
Mon, 18 May 2015 14:41:30 +0000 (16:41 +0200)
This makes it where the natural construction can be used of something
like:

new ChapterFrame("ID", ... )

Closes #514

taglib/mpeg/id3v2/frames/chapterframe.cpp
tests/test_id3v2.cpp

index ab0e3e754bf7df1d1d22a697149a3a3ab7305f06..c6523883b41b09e466f4291d2ac04d2ea27f8133 100644 (file)
@@ -71,7 +71,12 @@ ChapterFrame::ChapterFrame(const ByteVector &elementID,
     ID3v2::Frame("CHAP")
 {
   d = new ChapterFramePrivate;
-  d->elementID = elementID;
+
+  // setElementID has a workaround for a previously silly API where you had to
+  // specifically include the null byte.
+
+  setElementID(elementID);
+
   d->startTime = startTime;
   d->endTime = endTime;
   d->startOffset = startOffset;
@@ -115,8 +120,9 @@ TagLib::uint ChapterFrame::endOffset() const
 void ChapterFrame::setElementID(const ByteVector &eID)
 {
   d->elementID = eID;
-  if(eID.at(eID.size() - 1) != char(0))
-    d->elementID.append(char(0));
+
+  if(d->elementID.endsWith(char(0)))
+    d->elementID = d->elementID.mid(0, d->elementID.size() - 1);
 }
 
 void ChapterFrame::setStartTime(const TagLib::uint &sT)
@@ -256,6 +262,7 @@ ByteVector ChapterFrame::renderFields() const
   ByteVector data;
 
   data.append(d->elementID);
+  data.append('\0');
   data.append(ByteVector::fromUInt(d->startTime, true));
   data.append(ByteVector::fromUInt(d->endTime, true));
   data.append(ByteVector::fromUInt(d->startOffset, true));
index 43eed5c4d402b4c0188da5520f065a7814bae375..f62001d4984b65e0afb25b274b9a25db8a6069aa 100644 (file)
@@ -965,7 +965,21 @@ public:
 
     ID3v2::ChapterFrame f3(ByteVector("C\x00", 2), 3, 5, 2, 3, frames);
     CPPUNIT_ASSERT_EQUAL(expected, f3.render());
-  }
+
+    frames.clear();
+    eF = new ID3v2::TextIdentificationFrame("TIT2");
+    eF->setText("CH1");
+    frames.append(eF);
+
+    ID3v2::ChapterFrame f4("C", 3, 5, 2, 3, frames);
+    CPPUNIT_ASSERT_EQUAL(expected, f4.render());
+
+    ID3v2::ChapterFrame f5("C", 3, 5, 2, 3);
+    eF = new ID3v2::TextIdentificationFrame("TIT2");
+    eF->setText("CH1");
+    f5.addEmbeddedFrame(eF);
+    CPPUNIT_ASSERT_EQUAL(expected, f5.render());
+}
 
   void testParseTableOfContentsFrame()
   {