]> granicus.if.org Git - clang/commitdiff
Revert "[Lex] TokenConcatenation now takes const Preprocessor"
authorEric Liu <ioeric@google.com>
Thu, 11 Oct 2018 17:50:04 +0000 (17:50 +0000)
committerEric Liu <ioeric@google.com>
Thu, 11 Oct 2018 17:50:04 +0000 (17:50 +0000)
This reverts commit r344262. This was an unintentional commit.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@344267 91177308-0d34-0410-b5e6-96231b3b80d8

lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h

index 828955dc100c2baa4db3431a844cc588c9cd09a6..d10b862ea0832c8139046777cfa33f22e476996d 100644 (file)
@@ -79,9 +79,9 @@ class FieldNode {
 protected:
   const FieldRegion *FR;
 
-  // TODO: This destructor shouldn't be virtual, but breaks buildbots with
-  // -Werror -Wnon-virtual-dtor.
-  virtual ~FieldNode() = default;
+  /// FieldNodes are never meant to be created on the heap, see
+  /// FindUninitializedFields::addFieldToUninits().
+  /* non-virtual */ ~FieldNode() = default;
 
 public:
   FieldNode(const FieldRegion *FR) : FR(FR) {}