]> granicus.if.org Git - php/commitdiff
check the return value of getgroups() for -1 (coverity issue #390)
authorAntony Dovgal <tony2001@php.net>
Fri, 21 Sep 2007 14:05:01 +0000 (14:05 +0000)
committerAntony Dovgal <tony2001@php.net>
Fri, 21 Sep 2007 14:05:01 +0000 (14:05 +0000)
ext/standard/filestat.c

index 3ace3c755176951340eae378fddaf3bf603de771..60a3a53ccb15cf61285da4a4a617aa40be812464 100644 (file)
@@ -877,7 +877,7 @@ PHPAPI void php_stat(const char *filename, php_stat_len filename_length, int typ
                        gid_t *gids;
 
                        groups = getgroups(0, NULL);
-                       if(groups) {
+                       if(groups > 0) {
                                gids=(gid_t *)safe_emalloc(groups, sizeof(gid_t), 0);
                                n=getgroups(groups, gids);
                                for(i=0;i<n;i++){