Issue #21481: Teach argparse equality tests to return NotImplemented when comparing...

diff --git a/Lib/argparse.py b/Lib/argparse.py
index a4009d0826ff4f6b2828662ed2f48a85b14fc891..b5bb19a02f5283015b8fe023759cc7f0a1fd124e 100644 (file)
--- a/Lib/argparse.py
+++ b/Lib/argparse.py
@@ -1157,9 +1157,13 @@ class Namespace(_AttributeHolder):
     __hash__ = None
 
     def __eq__(self, other):
+        if not isinstance(other, Namespace):
+            return NotImplemented
         return vars(self) == vars(other)
 
     def __ne__(self, other):
+        if not isinstance(other, Namespace):
+            return NotImplemented
         return not (self == other)
 
     def __contains__(self, key):

diff --git a/Lib/test/test_argparse.py b/Lib/test/test_argparse.py
index fdf2b67dc47998906b05f83706ebf0108ac6b787..0df66ad18940dbf014b7ca1a8faa88e40f325bb5 100644 (file)
--- a/Lib/test/test_argparse.py
+++ b/Lib/test/test_argparse.py
@@ -4453,6 +4453,12 @@ class TestNamespace(TestCase):
         self.assertTrue(ns2 != ns3)
         self.assertTrue(ns2 != ns4)
 
+    def test_equality_returns_notimplemeted(self):
+        # See issue 21481
+        ns = argparse.Namespace(a=1, b=2)
+        self.assertIs(ns.__eq__(None), NotImplemented)
+        self.assertIs(ns.__ne__(None), NotImplemented)
+
 
 # ===================
 # File encoding tests

diff --git a/Misc/NEWS b/Misc/NEWS
index 34c007489dcd84e841aa1873eb92920338348278..663f389254c5d0e561271f9de36ad5c05957c3f2 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -21,6 +21,9 @@ Library
 - Issue #8743: Fix interoperability between set objects and the
   collections.Set() abstract base class.
 
+- Issue #21481:  Argparse equality and inequality tests now return 
+  NotImplemented when comparing to an unknown type.
+
 Tests
 -----