The documentation says: ISAPIReadAheadBuffer defaults to 49152 bytes,

  which is exactly 48 kb. But the module actually uses a default of 48192
  bytes. This seems to be a typo. Instead of changing the documentation I
  attached a patch for mod_isapi.c to set the default value of
  ISAPIReadAheadBuffer to 49152.

Submitted by: Astrid Ke�ler <kess@kess-net.de>

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@96534 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/CHANGES b/CHANGES
index 3d411b6e203c4a7618eb55dac418faf9be805519..bb9264098bfa4e3b10d0e4319def995714c5eae8 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,5 +1,8 @@
 Changes with Apache 2.0.41
 
+  *) Correct ISAPIReadAheadBuffer to default to 49152, per mod_isapi docs.
+     [André Malo, Astrid Keßler <kess@kess-net.de>]
+
   *) Fix Segfault in mod_cache. [Kris Verbeeck <Kris.Verbeeck@ubizen.com>]
 
   *) Fix a null pointer dereference in the merge_env_dir_configs

diff --git a/modules/arch/win32/mod_isapi.c b/modules/arch/win32/mod_isapi.c
index 21cf62ca23661667f53fb298b436d2becc7f4775..040c4f81f50f462b922265f44070f61a4266c9af 100644 (file)
--- a/modules/arch/win32/mod_isapi.c
+++ b/modules/arch/win32/mod_isapi.c
@@ -209,7 +209,7 @@ static const command_rec isapi_cmds[] = {
     AP_INIT_TAKE1("ISAPIReadAheadBuffer", ap_set_int_slot,
         (void *)APR_OFFSETOF(isapi_dir_conf, read_ahead_buflen), 
         OR_FILEINFO, "Maximum client request body to initially pass to the"
-                     " ISAPI handler (default: 48192)"),
+                     " ISAPI handler (default: 49152)"),
     AP_INIT_FLAG("ISAPILogNotSupported", ap_set_flag_slot,
         (void *)APR_OFFSETOF(isapi_dir_conf, log_unsupported), 
         OR_FILEINFO, "Log requests not supported by the ISAPI server"
@@ -1362,7 +1362,7 @@ apr_status_t isapi_handler (request_rec *r)
     
     /* Fixup defaults for dconf */
     cid->dconf.read_ahead_buflen = (dconf->read_ahead_buflen == ISAPI_UNDEF)
-                                     ? 48192 : dconf->read_ahead_buflen;
+                                     ? 49152 : dconf->read_ahead_buflen;
     cid->dconf.log_unsupported   = (dconf->log_unsupported == ISAPI_UNDEF)
                                      ? 0 : dconf->log_unsupported;
     cid->dconf.log_to_errlog     = (dconf->log_to_errlog == ISAPI_UNDEF)