Fix pg_upgrade to handle event triggers in extensions correctly.

pg_dump with --binary-upgrade must emit ALTER EXTENSION ADD commands
for all objects that are members of extensions.  It forgot to do so for
event triggers, as per bug #15310 from Nick Barnes.  Back-patch to 9.3
where event triggers were introduced.

Haribabu Kommi

Discussion: https://postgr.es/m/153360083872.1395.4593932457718151600@wrigleys.postgresql.org

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 0c60152eeb74daacc068c762f6e8b20f4d3f7641..34cbf6ca64034f161cc43982711e114546e8c634 100644 (file)
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -14692,6 +14692,10 @@ dumpEventTrigger(Archive *fout, EventTriggerInfo *evtinfo)
        appendPQExpBuffer(delqry, "DROP EVENT TRIGGER %s;\n",
                                          qevtname);
 
+       if (binary_upgrade)
+               binary_upgrade_extension_member(query, &evtinfo->dobj,
+                                                                               "EVENT TRIGGER", qevtname, NULL);
+
        ArchiveEntry(fout, evtinfo->dobj.catId, evtinfo->dobj.dumpId,
                                 evtinfo->dobj.name, NULL, NULL,
                                 evtinfo->evtowner, false,