]> granicus.if.org Git - python/commitdiff
Merged revisions 78653 via svnmerge from
authorFlorent Xicluna <florent.xicluna@gmail.com>
Thu, 4 Mar 2010 16:10:10 +0000 (16:10 +0000)
committerFlorent Xicluna <florent.xicluna@gmail.com>
Thu, 4 Mar 2010 16:10:10 +0000 (16:10 +0000)
svn+ssh://pythondev@svn.python.org/python/trunk

........
  r78653 | florent.xicluna | 2010-03-04 16:58:54 +0100 (jeu, 04 mar 2010) | 2 lines

  #7805: wait until all workers are started before collecting their PIDs
........

Lib/test/test_multiprocessing.py

index be923bdab8f045e1e38b26c3cd69cda430bdd50e..7fcbdc3278ca421959cdb1c74258732860d3ab5c 100644 (file)
@@ -1071,8 +1071,16 @@ class _TestPoolWorkerLifetime(BaseTestCase):
             self.assertEqual(res.get(), sqr(j))
         # Refill the pool
         p._repopulate_pool()
-        # Finally, check that the worker pids have changed
+        # Wait until all workers are alive
+        countdown = 5
+        while countdown and not all(w.is_alive() for w in p._pool):
+            countdown -= 1
+            time.sleep(DELTA)
         finalworkerpids = [w.pid for w in p._pool]
+        # All pids should be assigned.  See issue #7805.
+        self.assertNotIn(None, origworkerpids)
+        self.assertNotIn(None, finalworkerpids)
+        # Finally, check that the worker pids have changed
         self.assertNotEqual(sorted(origworkerpids), sorted(finalworkerpids))
         p.close()
         p.join()