]> granicus.if.org Git - python/commitdiff
Merged revisions 78721 via svnmerge from
authorFlorent Xicluna <florent.xicluna@gmail.com>
Sat, 6 Mar 2010 11:52:51 +0000 (11:52 +0000)
committerFlorent Xicluna <florent.xicluna@gmail.com>
Sat, 6 Mar 2010 11:52:51 +0000 (11:52 +0000)
svn+ssh://pythondev@svn.python.org/python/trunk

........
  r78721 | florent.xicluna | 2010-03-06 10:54:14 +0100 (sam, 06 mar 2010) | 2 lines

  #2777: Apply same recipe on win32, i.e. do not inherit file handles.
........

Lib/test/test_subprocess.py

index b5ad6bacaf77223c2d5fd6d203b1dd1b19bf26a1..a5e831db0d339832eb249a103b9f037ca5a08380 100644 (file)
@@ -767,21 +767,23 @@ class Win32ProcessTestCase(unittest.TestCase):
         self.assertEqual(rc, 47)
 
     def test_send_signal(self):
-        p = subprocess.Popen([sys.executable, "-c", "input()"])
+        # Do not inherit file handles from the parent.
+        # It should fix failure on some platforms.
+        p = subprocess.Popen([sys.executable, "-c", "input()"], close_fds=True)
 
         self.assertIs(p.poll(), None)
         p.send_signal(signal.SIGTERM)
         self.assertNotEqual(p.wait(), 0)
 
     def test_kill(self):
-        p = subprocess.Popen([sys.executable, "-c", "input()"])
+        p = subprocess.Popen([sys.executable, "-c", "input()"], close_fds=True)
 
         self.assertIs(p.poll(), None)
         p.kill()
         self.assertNotEqual(p.wait(), 0)
 
     def test_terminate(self):
-        p = subprocess.Popen([sys.executable, "-c", "input()"])
+        p = subprocess.Popen([sys.executable, "-c", "input()"], close_fds=True)
 
         self.assertIs(p.poll(), None)
         p.terminate()