]> granicus.if.org Git - php/commitdiff
Remove a useless memory write in zend_llist_del_element
authorPierrick Charron <pierrick@php.net>
Wed, 26 Dec 2012 01:45:24 +0000 (20:45 -0500)
committerPierrick Charron <pierrick@php.net>
Wed, 26 Dec 2012 01:45:24 +0000 (20:45 -0500)
The zend_llist_element *next pointer is not necessary and removing
it will also remove a write on memory

Zend/zend_llist.c

index 4656420781d0f05c725fdd82980507df48e1f2a0..26baf4d958cf0e114cc61e4a847f5bf63828e847 100644 (file)
@@ -91,15 +91,13 @@ ZEND_API void zend_llist_prepend_element(zend_llist *l, void *element)
 ZEND_API void zend_llist_del_element(zend_llist *l, void *element, int (*compare)(void *element1, void *element2))
 {
        zend_llist_element *current=l->head;
-       zend_llist_element *next;
 
        while (current) {
-               next = current->next;
                if (compare(current->data, element)) {
                        DEL_LLIST_ELEMENT(current, l);
                        break;
                }
-               current = next;
+               current = current->next;
        }
 }