]> granicus.if.org Git - postgresql/commitdiff
revert prior patch to fsync directories until portability problems exposed by build...
authorGreg Stark <stark@mit.edu>
Tue, 16 Feb 2010 00:01:11 +0000 (00:01 +0000)
committerGreg Stark <stark@mit.edu>
Tue, 16 Feb 2010 00:01:11 +0000 (00:01 +0000)
src/port/copydir.c

index 4cc6e4e0b6f49b288d27e18c8fbdb56607823c20..cfdaddb28cea49e81e9a6c23e245d41ecdd79d85 100644 (file)
@@ -11,7 +11,7 @@
  *     as a service.
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/port/copydir.c,v 1.18.2.2 2010/02/14 17:50:39 stark Exp $
+ *       $PostgreSQL: pgsql/src/port/copydir.c,v 1.18.2.3 2010/02/16 00:01:11 stark Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -50,7 +50,6 @@ copydir(char *fromdir, char *todir, bool recurse)
 {
        DIR                *xldir;
        struct dirent *xlde;
-       int         dirfd;
        char            fromfile[MAXPGPATH];
        char            tofile[MAXPGPATH];
 
@@ -92,26 +91,6 @@ copydir(char *fromdir, char *todir, bool recurse)
        }
 
        FreeDir(xldir);
-
-       /*
-        * fsync the directory to make sure not just the data but also the
-        * new directory file entries have reached the disk. While needed
-        * by most filesystems, the window got bigger with newer ones like
-        * ext4.
-        */
-       dirfd = BasicOpenFile(todir,
-                             O_RDONLY | PG_BINARY,
-                             S_IRUSR | S_IWUSR);
-       if(dirfd == -1)
-               ereport(ERROR,
-                       (errcode_for_file_access(),
-                        errmsg("could not open directory for fsync \"%s\": %m", todir)));
-
-       if(pg_fsync(dirfd) == -1)
-               ereport(ERROR,
-                               (errcode_for_file_access(),
-                                errmsg("could not fsync directory \"%s\": %m", todir)));
-       close(dirfd);
 }
 
 /*