]> granicus.if.org Git - graphviz/commitdiff
rtest.py: remove 'REFDIR' parameter to 'doDiff'
authorMatthew Fernandez <matthew.fernandez@gmail.com>
Thu, 2 Sep 2021 03:26:54 +0000 (20:26 -0700)
committerMatthew Fernandez <matthew.fernandez@gmail.com>
Sat, 4 Sep 2021 15:21:19 +0000 (08:21 -0700)
This parameter is available as a global. This change removes a Pylint
redefined-outer-name warning and a Pylint too-many-arguments warning.

rtest/rtest.py

index 6d8e52671b9369927aedbc9ffaa2033448519d8d..0ebd9e234211aed88b1c842fadcf45c0ab7b2a15 100755 (executable)
@@ -104,7 +104,7 @@ def readTest():
       "SUBTESTS": SUBTESTS,
       }
 
-def doDiff(OUTFILE, OUTDIR, REFDIR, testname, subtest_index, fmt):
+def doDiff(OUTFILE, OUTDIR, testname, subtest_index, fmt):
   """
   Compare old and new output and report if different.
    Args: testname index fmt
@@ -310,7 +310,7 @@ def doTest(TEST):
     elif GENERATE:
       continue
     elif os.path.exists(os.path.join(REFDIR, OUTFILE)):
-      doDiff(OUTFILE, OUTDIR, REFDIR, TESTNAME, i, SUBTEST["FMT"])
+      doDiff(OUTFILE, OUTDIR, TESTNAME, i, SUBTEST["FMT"])
     else:
       sys.stderr.write(f"Test {TESTNAME}:{i} : == No file {REFDIR}/{OUTFILE} "
                        "for comparison ==\n")