Replace a cast with a dyn_cast as suggested by Doug.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@72624 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Sema/SemaInherit.cpp b/lib/Sema/SemaInherit.cpp
index 1eccc1f193fbad8b7e5f83b4802f9389196fb27a..1b968f0fbccef8fa2c002457b8c52cac4c7aca42 100644 (file)
--- a/lib/Sema/SemaInherit.cpp
+++ b/lib/Sema/SemaInherit.cpp
@@ -195,13 +195,14 @@ bool Sema::LookupInBases(CXXRecordDecl *Class,
       Paths.ScratchPath.Decls = 
         BaseRecord->lookup(Context, Criteria.Method->getDeclName());
       while (Paths.ScratchPath.Decls.first != Paths.ScratchPath.Decls.second) {
-        CXXMethodDecl *MD = 
-          cast<CXXMethodDecl>(*Paths.ScratchPath.Decls.first);
-
-        OverloadedFunctionDecl::function_iterator MatchedDecl;
-        if (MD->isVirtual() && !IsOverload(Criteria.Method, MD, MatchedDecl)) {
-          FoundPathToThisBase = true;
-          break;
+        if (CXXMethodDecl *MD = 
+              dyn_cast<CXXMethodDecl>(*Paths.ScratchPath.Decls.first)) {
+          OverloadedFunctionDecl::function_iterator MatchedDecl;
+          if (MD->isVirtual() && 
+              !IsOverload(Criteria.Method, MD, MatchedDecl)) {
+            FoundPathToThisBase = true;
+            break;
+          }
         }
         
         ++Paths.ScratchPath.Decls.first;

diff --git a/test/SemaCXX/abstract.cpp b/test/SemaCXX/abstract.cpp
index cf7322156fa2028a4028e2fb67e4e03fbc614197..dc764da5322b57da7f4bd1b91a4b647034a98a64 100644 (file)
--- a/test/SemaCXX/abstract.cpp
+++ b/test/SemaCXX/abstract.cpp
@@ -118,3 +118,11 @@ void foo(void)
        B b;
 }
 
+struct K {
+ int f;
+ virtual ~K();
+};
+
+struct L : public K {
+ void f();
+};