]> granicus.if.org Git - llvm/commitdiff
Add a missing return to the move assignment operator for
authorChandler Carruth <chandlerc@gmail.com>
Fri, 4 Nov 2016 07:16:33 +0000 (07:16 +0000)
committerChandler Carruth <chandlerc@gmail.com>
Fri, 4 Nov 2016 07:16:33 +0000 (07:16 +0000)
SequenceNumberManager.

Sadly, we don't have any unittests for this class because it is
a private class. Since it seems to have a nice isolated and testable
interface, it'd be great to extract it to a detail namespace and write
unit tests for it as then we could catch issues. I'll probably pester
Lang about that or some alternative refactoring.

This was noticed by PVS-Studio.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@285990 91177308-0d34-0410-b5e6-96231b3b80d8

include/llvm/ExecutionEngine/Orc/RPCUtils.h

index b6c7b2e7bbc39ccdfdd24288cfad51ba031a9c25..436c037e920a04ccc558e69ac20e5818569766ef 100644 (file)
@@ -700,6 +700,7 @@ private:
     SequenceNumberManager &operator=(SequenceNumberManager &&Other) {
       NextSequenceNumber = std::move(Other.NextSequenceNumber);
       FreeSequenceNumbers = std::move(Other.FreeSequenceNumbers);
+      return *this;
     }
 
     void reset() {