]> granicus.if.org Git - python/commitdiff
http://bugs.python.org/issue6267
authorKristján Valur Jónsson <kristjan@ccpgames.com>
Fri, 3 Jul 2009 23:26:02 +0000 (23:26 +0000)
committerKristján Valur Jónsson <kristjan@ccpgames.com>
Fri, 3 Jul 2009 23:26:02 +0000 (23:26 +0000)
Incorrect exception handling for xmlrp client retry

Lib/xmlrpclib.py

index 160b61c8e041da502d1ca8c2700cb7e85955640e..da3fb5a91ccc852ba583e30c58f83dc8e238195f 100644 (file)
@@ -1253,11 +1253,11 @@ class Transport:
         for i in (0, 1):
             try:
                 return self.single_request(host, handler, request_body, verbose)
-            except (socket.error, httplib.HTTPException), e:
-                retry = (errno.ECONNRESET,
-                         errno.ECONNABORTED,
-                         httplib.BadStatusLine) #close after we sent request
-                if i or e[0] not in retry:
+            except socket.error, e:
+                if i or e.errno not in (errno.ECONNRESET, errno.ECONNABORTED):
+                    raise
+            except http.client.BadStatusLine: #close after we sent request
+                if i:
                     raise
 
     ##