Don't pass NULL to fprintf, if a bogus connection string is given to pg_dump.

Back-patch to all supported branches.

diff --git a/src/bin/pg_dump/pg_backup_db.c b/src/bin/pg_dump/pg_backup_db.c
index b04784e0f9a648ef7a96bac7121d1812c8816d10..3bfcaf8db072c49f9f99df5b00878c2afe9f19c4 100644 (file)
--- a/src/bin/pg_dump/pg_backup_db.c
+++ b/src/bin/pg_dump/pg_backup_db.c
@@ -255,7 +255,8 @@ ConnectDatabase(Archive *AHX,
        /* check to see that the backend connection was successfully made */
        if (PQstatus(AH->connection) == CONNECTION_BAD)
                die_horribly(AH, modulename, "connection to database \"%s\" failed: %s",
-                                        PQdb(AH->connection), PQerrorMessage(AH->connection));
+                                        PQdb(AH->connection) ? PQdb(AH->connection) : "",
+                                        PQerrorMessage(AH->connection));
 
        /* check for version mismatch */
        _check_database_version(AH);