]> granicus.if.org Git - clang/commitdiff
Fix getCustomDiagID() usage in example code
authorAlp Toker <alp@nuanti.com>
Sat, 21 Dec 2013 05:19:58 +0000 (05:19 +0000)
committerAlp Toker <alp@nuanti.com>
Sat, 21 Dec 2013 05:19:58 +0000 (05:19 +0000)
This was setting a bad example. DiagIDs are a limited resource and the message
argument is evaluated as a format string.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@197855 91177308-0d34-0410-b5e6-96231b3b80d8

examples/PrintFunctionNames/PrintFunctionNames.cpp

index f6e75cc2d3a02ce7f95452b83f53018106243397..3f18cd45e56463749d3bb5dbdfc48aff5631bf2b 100644 (file)
@@ -48,9 +48,9 @@ protected:
       // Example error handling.
       if (args[i] == "-an-error") {
         DiagnosticsEngine &D = CI.getDiagnostics();
-        unsigned DiagID = D.getCustomDiagID(
-          DiagnosticsEngine::Error, "invalid argument '" + args[i] + "'");
-        D.Report(DiagID);
+        unsigned DiagID = D.getCustomDiagID(DiagnosticsEngine::Error,
+                                            "invalid argument '%0'");
+        D.Report(DiagID) << args[i];
         return false;
       }
     }