check return value of fgets 620/head
authorStefan Assmann <sassmann@kpanic.de>
Tue, 30 May 2017 06:25:33 +0000 (08:25 +0200)
committerRichard Russon <rich@flatcap.org>
Wed, 7 Jun 2017 21:57:51 +0000 (22:57 +0100)
Following warning was observed:
 init.c: In function 'mutt_init':
 mutt.h:53:15: warning: ignoring return value of 'fgets_unlocked', declared with attribute warn_unused_result [-Wunused-result]
  #define fgets fgets_unlocked

 init.c:4053:7: note: in expansion of macro 'fgets'
        fgets(buffer, sizeof(buffer), f);
        ^~~~~
Added code that checks return value.

Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
init.c

diff --git a/init.c b/init.c
index 49c0c7e617e61bf8bfb932ed72fa2993e930be0e..63226e6966caeff0fd994684a48b277504dbd978 100644 (file)
--- a/init.c
+++ b/init.c
@@ -4049,8 +4049,8 @@ void mutt_init(int skip_sys_rc, struct List *commands)
 
     if ((f = safe_fopen(SYSCONFDIR "/nntpserver", "r")))
     {
-      buffer[0] = '\0';
-      fgets(buffer, sizeof(buffer), f);
+      if (fgets(buffer, sizeof(buffer), f) == NULL)
+        buffer[0] = '\0';
       p = buffer;
       SKIPWS(p);
       c = p;