]> granicus.if.org Git - php/commitdiff
Avoid convert_to_long_ex usage in readline
authorNikita Popov <nikita.ppv@gmail.com>
Tue, 23 Jun 2020 10:35:51 +0000 (12:35 +0200)
committerNikita Popov <nikita.ppv@gmail.com>
Tue, 23 Jun 2020 10:35:51 +0000 (12:35 +0200)
ext/readline/readline.c

index 327c55f281e61f9f480deed765bcd548e527f88f..deb55c834e816e0913ce9e7bce265471123dc261 100644 (file)
@@ -201,8 +201,7 @@ PHP_FUNCTION(readline_info)
                } else if (!strcasecmp(what, "done")) {
                        oldval = rl_done;
                        if (value) {
-                               convert_to_long_ex(value);
-                               rl_done = Z_LVAL_P(value);
+                               rl_done = zval_get_long(value);
                        }
                        RETVAL_LONG(oldval);
                } else if (!strcasecmp(what, "pending_input")) {
@@ -239,8 +238,7 @@ PHP_FUNCTION(readline_info)
                } else if (!strcasecmp(what, "erase_empty_line")) {
                        oldval = rl_erase_empty_line;
                        if (value) {
-                               convert_to_long_ex(value);
-                               rl_erase_empty_line = Z_LVAL_P(value);
+                               rl_erase_empty_line = zval_get_long(value);
                        }
                        RETVAL_LONG(oldval);
 #endif
@@ -261,8 +259,7 @@ PHP_FUNCTION(readline_info)
                } else if (!strcasecmp(what, "attempted_completion_over")) {
                        oldval = rl_attempted_completion_over;
                        if (value) {
-                               convert_to_long_ex(value);
-                               rl_attempted_completion_over = Z_LVAL_P(value);
+                               rl_attempted_completion_over = zval_get_long(value);
                        }
                        RETVAL_LONG(oldval);
                }