Avoid implicit conversion of chars to booleans.

diff --git a/ChangeLog b/ChangeLog
index 231e7c9d62ca78947be13f4cc80ebf441b8f4051..a636ba3bc30631d1578a9c331d4307ec26733353 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2008-05-26  Nicolas François  <nicolas.francois@centraliens.net>
+
+       * libmisc/setupenv.c: Avoid implicit conversion of chars to
+       booleans.
+
 2008-05-26  Nicolas François  <nicolas.francois@centraliens.net>
 
        * libmisc/copydir.c: selinux_checked, selinux_enabled, and set_orig

diff --git a/libmisc/setupenv.c b/libmisc/setupenv.c
index 8147d1d0e911311b013eb43dba6124a61084b5ae..8eb383d010f5ed7606ee34f3992f3532d8390a02 100644 (file)
--- a/libmisc/setupenv.c
+++ b/libmisc/setupenv.c
@@ -229,7 +229,7 @@ void setup_env (struct passwd *info)
         * Create the SHELL environmental variable and export it.
         */
 
-       if (info->pw_shell == (char *) 0 || !*info->pw_shell) {
+       if ((NULL == info->pw_shell) || ('\0' == *info->pw_shell)) {
                static char temp_pw_shell[] = "/bin/sh";
 
                info->pw_shell = temp_pw_shell;