Check that f.keys() == [] right after creation -- this prevents bugs

like the one I just fixed to come back and haunt us.

diff --git a/Lib/test/test_bsddb.py b/Lib/test/test_bsddb.py
index b59a4e0a1156f94099a7fbadd4716135485c079b..192c6e2f2eca5676e0341edc9bc91902c1dae416 100755 (executable)
--- a/Lib/test/test_bsddb.py
+++ b/Lib/test/test_bsddb.py
@@ -6,7 +6,7 @@
 import os
 import bsddb
 import tempfile
-from test_support import verbose
+from test_support import verbose, verify
 
 def test(openmethod, what):
 
@@ -15,6 +15,7 @@ def test(openmethod, what):
 
     fname = tempfile.mktemp()
     f = openmethod(fname, 'c')
+    verify(f.keys() == [])
     if verbose:
         print 'creation...'
     f['0'] = ''

diff --git a/Lib/test/test_dbm.py b/Lib/test/test_dbm.py
index 94949cf6fcb93293eb078498ea6b23377eca5f8d..b74194a615c509c1e805e405cdd475fa72e7283d 100755 (executable)
--- a/Lib/test/test_dbm.py
+++ b/Lib/test/test_dbm.py
@@ -4,11 +4,12 @@
 """
 import dbm
 from dbm import error
-from test_support import verbose
+from test_support import verbose, verify
 
 filename = '/tmp/delete_me'
 
 d = dbm.open(filename, 'c')
+verify(d.keys() == [])
 d['a'] = 'b'
 d['12345678910'] = '019237410982340912840198242'
 d.keys()

diff --git a/Lib/test/test_gdbm.py b/Lib/test/test_gdbm.py
index 67c67eb6e71b3422c2e0064389fd8000ffcd3f28..d3640160c4f70d093024737e72f39dcb7e84e65c 100755 (executable)
--- a/Lib/test/test_gdbm.py
+++ b/Lib/test/test_gdbm.py
@@ -5,11 +5,12 @@
 
 import gdbm
 from gdbm import error
-from test_support import verbose, TestFailed
+from test_support import verbose, verify, TestFailed
 
 filename= '/tmp/delete_me'
 
 g = gdbm.open(filename, 'c')
+verify(g.keys() == [])
 g['a'] = 'b'
 g['12345678910'] = '019237410982340912840198242'
 a = g.keys()