xml_isentity: use ctype.h functions for readability

This has no functional impact, but just makes the code simpler to read and less
error prone.

diff --git a/lib/common/xml.c b/lib/common/xml.c
index 100c6a9d4174dabd6ee4d75ad6eddbd9d51f5353..0d19c610b11cfbb7defc6bb76ea7685acc4188b0 100644 (file)
--- a/lib/common/xml.c
+++ b/lib/common/xml.c
@@ -1,6 +1,7 @@
 #include <common/memory.h>
 #include <common/types.h>
 #include <common/utils.h>
+#include <ctype.h>
 
 /* return true if *s points to &[A-Za-z]+;      (e.g. &Ccedil; )
  *                          or &#[0-9]*;        (e.g. &#38; )
@@ -16,12 +17,10 @@ static int xml_isentity(char *s)
        s++;
        if (*s == 'x' || *s == 'X') {
            s++;
-           while ((*s >= '0' && *s <= '9')
-                  || (*s >= 'a' && *s <= 'f')
-                  || (*s >= 'A' && *s <= 'F'))
+           while (isxdigit(*s))
                s++;
        } else {
-           while (*s >= '0' && *s <= '9')
+           while (isdigit(*s))
                s++;
        }
     } else {