Bug #767111: fix long-standing bug in urllib which caused an

AttributeError instead of an IOError when the server's response didn't
contain a valid HTTP status line.

diff --git a/Lib/test/test_urllib.py b/Lib/test/test_urllib.py
index 4579c479d1478bbf06425104ee2f74531499514b..294ed5e06a203a3d13669a186069b6a343742596 100644 (file)
--- a/Lib/test/test_urllib.py
+++ b/Lib/test/test_urllib.py
@@ -122,6 +122,15 @@ class urlopen_HttpTests(unittest.TestCase):
         finally:
             self.unfakehttp()
 
+    def test_empty_socket(self):
+        """urlopen() raises IOError if the underlying socket does not send any
+        data. (#1680230) """
+        self.fakehttp('')
+        try:
+            self.assertRaises(IOError, urllib.urlopen, 'http://something')
+        finally:
+            self.unfakehttp()
+
 class urlretrieve_FileTests(unittest.TestCase):
     """Test urllib.urlretrieve() on local files"""
 

diff --git a/Lib/urllib.py b/Lib/urllib.py
index 0fc9b28f4556768cf4ce59909ac13b5c8c96acb6..c000f1129eae19b0e2990d07695dc616a7b7f7f5 100644 (file)
--- a/Lib/urllib.py
+++ b/Lib/urllib.py
@@ -326,6 +326,10 @@ class URLopener:
         if data is not None:
             h.send(data)
         errcode, errmsg, headers = h.getreply()
+        if errcode == -1:
+            # something went wrong with the HTTP status line
+            raise IOError, ('http protocol error', 0,
+                            'got a bad status line', None)
         fp = h.getfile()
         if errcode == 200:
             return addinfourl(fp, headers, "http:" + url)
@@ -413,6 +417,10 @@ class URLopener:
             if data is not None:
                 h.send(data)
             errcode, errmsg, headers = h.getreply()
+            if errcode == -1:
+                # something went wrong with the HTTP status line
+                raise IOError, ('http protocol error', 0,
+                                'got a bad status line', None)
             fp = h.getfile()
             if errcode == 200:
                 return addinfourl(fp, headers, "https:" + url)

diff --git a/Misc/NEWS b/Misc/NEWS
index 355a827aa494460fd57596d75198048578017280..be9e972ae81b9bae5eead5107577de94795074ca 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -170,6 +170,10 @@ Core and builtins
 Library
 -------
 
+- Bug #767111: fix long-standing bug in urllib which caused an
+  AttributeError instead of an IOError when the server's response didn't
+  contain a valid HTTP status line.
+
 - Patch #957650: "%var%" environment variable references are now properly
   expanded in ntpath.expandvars(), also "~user" home directory references
   are recognized and handled on Windows.